Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Requires a prefixed "v" when parsing git tag name #3163

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Requires a prefixed "v" when parsing git tag name #3163

merged 1 commit into from
Jun 5, 2019

Conversation

mitchhentges
Copy link
Contributor

@mitchhentges mitchhentges commented Jun 5, 2019 •
edited
Loading

Fixes #3162

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

Merge checklist

  • Update wiki to recommend a prefixed "v"

@mitchhentges mitchhentges requested review from a team as code owners June 5, 2019 11:29
JohanLorenzo
JohanLorenzo approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@JohanLorenzo JohanLorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mitchhentges mitchhentges merged commit b5c336a into mozilla-mobile:master Jun 5, 2019
@mitchhentges mitchhentges deleted the 3162-tag-name-prefix branch June 5, 2019 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JohanLorenzo JohanLorenzo JohanLorenzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Beta/Production automation should expect a prefixed "v" in the tag version
2 participants
@mitchhentges @JohanLorenzo