Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

(Do Not Merge til 24th) Docker update for #3411 #3412

Merged
merged 1 commit into from
Jun 27, 2019
Merged

(Do Not Merge til 24th) Docker update for #3411 #3412

merged 1 commit into from
Jun 27, 2019

Conversation

nojunpark
Copy link

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@nojunpark nojunpark requested review from a team as code owners June 13, 2019 03:06
@nojunpark nojunpark changed the title Docker update for #3411 [Do Not Merge]Docker update for #3411 Jun 13, 2019
@nojunpark
Copy link
Author

Before this PR can be merged, a new docker image with tag 1.4 need to be uploaded

@nojunpark nojunpark requested a review from pocmo June 13, 2019 06:15
Copy link
Contributor

@pocmo pocmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good.

@nojunpark
Copy link
Author

@pocmo I'm getting "Artifact "public/actions.json" not found at "/opt/fenix/actions.json" error msg, do you think it's because I'm cleaning something wrong?

@nojunpark nojunpark changed the title [Do Not Merge]Docker update for #3411 [WIP]Docker update for #3411 Jun 13, 2019
increase java heap size
delete files to save docker size
@nojunpark nojunpark changed the title [WIP]Docker update for #3411 Docker update for #3411 Jun 14, 2019
@ghost
Copy link

ghost commented Jun 14, 2019

lets land this after we've shipped - i would ike the build system to be the same for each RC and final build we do between now and then

@nojunpark
Copy link
Author

@sarentz sounds good, after code freeze it is unlikely that we really need this to be set up to detect the startup crash via UI tests. Monday after all hands should be good.

@nojunpark nojunpark changed the title Docker update for #3411 (Do Not Merge til 24th) Docker update for #3411 Jun 15, 2019
@nojunpark nojunpark merged commit c603c0e into mozilla-mobile:master Jun 27, 2019
@nojunpark nojunpark deleted the dockerUpdate branch September 10, 2019 01:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants