Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fix the mklink command in README.md #3820

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

rmisev
Copy link
Contributor

@rmisev rmisev commented Jul 1, 2019

The mklink /d creates a directory symbolic link. As here we need a file symbolic link, the /d switch must not be used.

See mklink documentation: https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/mklink

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

The `mklink /d` creates a directory symbolic link. As here we need a file symbolic link, the `/d` switch must not be used.

See `mklink` documentation: https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/mklink
@rmisev rmisev requested a review from a team as a code owner July 1, 2019 13:27
Copy link
Contributor

@colintheshots colintheshots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@colintheshots colintheshots merged commit 144335d into mozilla-mobile:master Jul 1, 2019
@rmisev rmisev deleted the patch-1 branch July 1, 2019 19:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants