This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Re-enables pushing nightly to org.mozilla.fenix #3823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchhentges
force-pushed
the
reenable-nightly-legacy
branch
from
4e8c412
to
0bebd60
Compare
mitchhentges
commented
Jul 1, 2019
| return (build_tasks, signing_tasks, push_tasks) | ||
|
|
||
|
|
||
| def nightly_to_production_app(is_staging, version_name): |
There was a problem hiding this comment.
This function is very very similar to the one that used to be here
| @@ -131,6 +131,45 @@ def release(channel, is_staging, version_name): | |||
| signing_task_id, | |||
| apks=apk_paths, | |||
| channel=channel, | |||
| # TODO until org.mozilla.fenix.nightly is made public, put it on the internally-testable track | |||
| override_google_play_track=None if channel != "nightly" else "internal", | |||
There was a problem hiding this comment.
Note: we want to test org.mozilla.fenix.nightly before it's released.
By default, nightlies are published to the beta track, which is public.
So, we're going to override and publish on internal for a while, so we can internally test. Once org.mozilla.fenix.nightly is made public, we'll put this back to normal, so each nightly is automatically published publicly
mitchhentges
force-pushed
the
reenable-nightly-legacy
branch
from
0bebd60
to
acef3d6
Compare
pocmo
approved these changes
Jul 2, 2019
mitchhentges
force-pushed
the
reenable-nightly-legacy
branch
from
acef3d6
to
afa0a4f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to pushing Nightly to
org.mozilla.fenix.nightly, re-enable the legacy action of pushing it toorg.mozilla.fenixunder the nightly track.Pull Request checklist