This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Closes #3977: Add basic navigational UI tests #3978
Merged
+322
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhugman
previously requested changes
Jul 11, 2019
app/src/androidTest/java/org/mozilla/fenix/ui/NavigationToolbarTest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/ThreeDotMenuRobot.kt
Show resolved
Hide resolved
AaronMT
force-pushed
the
NavigationToolbar-UI-Tests
branch
3 times, most recently
from
ced66ba
to
e8ffe86
Compare
rpappalax
reviewed
Jul 15, 2019
app/src/androidTest/java/org/mozilla/fenix/ui/robots/NavigationToolbarRobot.kt
Outdated
Show resolved
Hide resolved
rpappalax
reviewed
Jul 15, 2019
app/src/androidTest/java/org/mozilla/fenix/ui/robots/ThreeDotMenuRobot.kt
Outdated
Show resolved
Hide resolved
rpappalax
reviewed
Jul 15, 2019
app/src/androidTest/java/org/mozilla/fenix/ui/robots/ThreeDotMenuRobot.kt
Outdated
Show resolved
Hide resolved
rpappalax
reviewed
Jul 15, 2019
app/src/androidTest/java/org/mozilla/fenix/ui/robots/ThreeDotMenuRobot.kt
Outdated
Show resolved
Hide resolved
rpappalax
reviewed
Jul 15, 2019
app/src/androidTest/java/org/mozilla/fenix/ui/robots/ThreeDotMenuRobot.kt
Outdated
Show resolved
Hide resolved
AaronMT
force-pushed
the
NavigationToolbar-UI-Tests
branch
from
e8ffe86
to
0ed5b37
Compare
- Adds UI tests (and assets) for basic navigation fix: review changes fix: linter cleanup fix: detekt cleanup fix: adjust wait approaches
AaronMT
force-pushed
the
NavigationToolbar-UI-Tests
branch
from
0ed5b37
to
432fa67
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
Tests: This PR includes thorough tests or an explanation of why it does not
Changelog: This PR includes a changelog entry or does not need one
Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features
Adds UI tests (and assets) for basic navigation