This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Fixes #4091 & Fixes #4092: Resolve issue with Search UI tests #4224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with Search UI tests
rpappalax
reviewed
Jul 22, 2019
| @@ -37,14 +38,14 @@ class SearchTest { | |||
| } | |||
| } | |||
|
|
|||
| @Ignore("This test cannot run on virtual devices due to camera permissions being required") | |||
There was a problem hiding this comment.
@npark-mozilla, it looks like the devices on Firebase have limited camera permissions. We can probably investigate this further later but, for now, it seems reasonable to me that we commit these tests and Ignore so they can be run locally as needed.
There was a problem hiding this comment.
yes that's fine, since we should only run tests on physical device on firebase.
rpappalax
approved these changes
Jul 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist