fixes #4193 - made close button for tabs more accessible.

[mcarare]

set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button and text as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible

Pull Request checklist

• Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
• Tests: This PR includes thorough tests or an explanation of why it does not
• Changelog: This PR includes a changelog entry or does not need one
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

[ekager]

Could you post a screenshot of the new tab for quick UX verification? :)

[sblatz]

This is the new layout:

[sblatz]

This still feels off to me, the top margin and the right margin on the close button do not match. Perhaps we just want to increase the 'clickableArea' as we do with other buttons?

[mcarare]

The top and right margin cannot be equal, cause the parent view also has margin. Also, I'm not sure If the Talkback rectangle is actually increased when using TouchDelegate.

[sblatz]

@mcarare I looked at this some more. Looks like increasing the touch size with a TouchDelegate does not make a larger selection square for TalkBack.

That being said, I was able to fix the visual margins on the button by just getting rid of the bottom constraint.

It now looks like this with TalkBack enabled and I think this is good to ship!

[mcarare]

Looks good. I think we should still check for UI feedback, because the vertically centered placement for the close button has already been accepted and merged for collections, and it would seem weird to have them placed differently for tabs.

[sblatz]

@AmyYLee Are you able to take a look at this and let us know whether or not the close button on the tab should be centered vertically or should be aligned to the top?

Centered

Top

[sblatz]

To clarify: we likely want consistent behavior here and should either revert the tab collection one to be top aligned or make this one centered :)

Tab Collection:

[AmyYLee]

I think these should be top aligned (collections and open tabs). @topotropic do you have feedback since you're working on the new collections design?

[topotropic]

no additional feedback at this point

[sblatz]

Created #5161 to address the tab in collection