Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #4495 - Clean up homescreen toolbar focus and content descriptions #4496

Merged
merged 1 commit into from Aug 5, 2019

Conversation

ekager
Copy link
Contributor

@ekager ekager commented Aug 2, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@ekager ekager requested a review from a team as a code owner August 2, 2019 16:12
@ekager ekager force-pushed the toolbar_polish branch 2 times, most recently from 23443e2 to 30bb984 Compare August 2, 2019 16:37
Copy link
Contributor

@colintheshots colintheshots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Do we want "enable private browsing" to be the first item read on the home screen just because it's located at the top? We could use setTraversalBefore if the ordering seems wrong.

@ekager
Copy link
Contributor Author

ekager commented Aug 5, 2019

I think we want to remove any accessibility changes here for now because it was causing other issues and I'm not sure we should be changing the hierarchy here, but I will link that setTraversalBefore in the ticket as something to explore.

@ekager ekager merged commit d0071d0 into mozilla-mobile:master Aug 5, 2019
@ekager ekager deleted the toolbar_polish branch August 5, 2019 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants