For #4438: Fix crash when opening any URL from URL bar w/ long press

[jyeontaek]

Pull Request checklist

• Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
• Tests: This PR includes thorough tests or an explanation of why it does not
• Changelog: This PR includes a changelog entry or does not need one
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

[csadilek]

Thanks for taking this on! Did you verify this also fixes the crashes described in #4486 (they have the same cause)

Can we also add a comment to onNewIntent why we're calling popBackStack there? It's not obvious to me :).

[jyeontaek]

I fixed the issue in a different way, so we don't need popBackStack after all! And yes, this fixes the crashes in #4486.

EDIT: Actually, this new solution does not work for some other case I found.

[jyeontaek]

I cleared both flags because FLAG_ACTIVITY_CLEAR_TASK was causing the issue, and since HomeActivity is SingleTask anyway, FLAG_ACTIVITY_NEW_TASK seemed redundant.

These flags were used to fix the "brief flash" problem in #3131, but even after removal, this problem didn't show up in several of my test devices.

[csadilek]

Change looks good to me!

I confirmed that it fixes the linked issues. I'd like to defer to @ekager and @sblatz though to make call re: custom tabs esp. #3131

[ekager]

Haha sorry I didn't realize when we chatted yesterday that I had added those flags 🙃 I will test this locally to check re #3131 today!

[ekager]

Yep this looks good!