-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add no-op experiment to test service-experiments integration #4551
Add no-op experiment to test service-experiments integration #4551
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending data review!
@@ -8,7 +8,7 @@ | |||
<th>key</th> | |||
<th>type</th> | |||
<th>description</th> | |||
<th>data deview</th> | |||
<th>data review</th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂️ Great catch!
dc28b86
to
f320417
Compare
Data review has passed, and I've updated this with the correct URL for it. I also rebased this PR atop master to fix a merge conflict. |
Codecov Report
@@ Coverage Diff @@
## master #4551 +/- ##
========================================
Coverage ? 6.73%
Complexity ? 152
========================================
Files ? 203
Lines ? 8453
Branches ? 1185
========================================
Hits ? 569
Misses ? 7845
Partials ? 39
Continue to review full report at Codecov.
|
@travis79 can you take a look at this? I think it is ready to merge. |
This looks good to me, my r+ still stands. Because I'm not a codeowner in this repo, we will still need someone with the correct permissions, such as @boek or @colintheshots to review as well. |
I just asked about this in the Fenix-team channel on slack to see if we can get a reviewer for this (or if there is a process we need to follow to get on the radar for reviews) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thanks.
This is for bug 1556751 This change helps verify that the service-experiments library is correctly integrated into Fenix, and that it can correctly enroll users in an experiment. This is exactly the same test that was done in mozilla-mobile/reference-browser#827. That reference browser population was not large enough to completely verify the library's behavior, but no red flags were raised.
I don't think this feature needs tests because it is itself a test of the experiments system.
I'm not sure if this change builds or not. I am having some trouble with the metrics metadata. I'm still working on this.
Pull Request checklist