For #4529, #4427: Resuming after restoring instance state breaks UI #4571
Conversation
There was a problem hiding this comment.
Nice! That's a big improvement @colintheshots. I've done a round of manual testing too to confirm. There's one use case though we haven't covered / that would regress with this:
- Load a page
- Settings -> Delete browsing data (Open tabs, delete)
- Hit back, and back again
Now the BrowserFragment is created without a session (and there will never be one) so it will remain a white screen forever. We somehow need to differentiate between the two cases here (still loading vs. there actually is no session).
I'll refactor my PR to handle this case as well. |
…g instance state breaks UI
There was a problem hiding this comment.
🚢
I think this is a big improvement over what we have now! One thing we will likely have to improve in the future is the empty state of BrowserFragment, which is just a white screen right now. If restoring sessions is slow or never completes we'll be showing a white screen. I think we either need a loading screen or think about how to handle that i.e. reference browser shows at least a functioning toolbar.
This PR fixes several issues having to do with race conditions when session restoration is still happening while the BrowserFragment is starting up. If the session ID comes up null, we don't want to skip initialization, nor do we want to return to the HomeFragment. The solution is deferring UI initialization until onSessionSelected in these cases.
Pull Request checklist