Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #4421: Adds Leanplum events and attributes #4626

Merged
merged 2 commits into from Aug 14, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Aug 8, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@sblatz
Copy link
Contributor Author

sblatz commented Aug 8, 2019

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • How often users are creating collections
  • How often users restore a tab from a previously created collection
  • How often users sign in to FxA
  • How often users sign up for FxA
  • How often users clear private data
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • To measure how engaged users are with FxA
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • N/A (These are baseline metrics)
  1. Can current instrumentation answer these questions?
  • No, while we are tracking some of these metrics in Glean, we need access to them in Leanplum for marketing usage.
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
  • All data is Category 1.
  1. How long will this data be collected?
  • Until 04/01/2020
  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled.
  1. Please provide a general description of how you will analyze this data.
  • Leanplum / Amplitude
  1. Where do you intend to share the results of your analysis?
  • Only on Leanplum, Amplitude and with mobile teams.

@sblatz sblatz force-pushed the leanplum-attrs branch 2 times, most recently from 125e696 to ce117b4 Compare August 13, 2019 15:46
@colintheshots colintheshots added the needs:data-review PR is awaiting a data review label Aug 13, 2019
@sblatz sblatz force-pushed the leanplum-attrs branch 5 times, most recently from 9de7871 to 058fca7 Compare August 14, 2019 15:49
@sblatz sblatz marked this pull request as ready for review August 14, 2019 15:49
@sblatz sblatz requested a review from a team as a code owner August 14, 2019 15:49
@codecov-io
Copy link

codecov-io commented Aug 14, 2019

Codecov Report

Merging #4626 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #4626      +/-   ##
===========================================
- Coverage      6.41%    6.4%   -0.01%     
  Complexity      154     154              
===========================================
  Files           205     205              
  Lines          8992    9005      +13     
  Branches       1321    1334      +13     
===========================================
  Hits            577     577              
- Misses         8376    8389      +13     
  Partials         39      39
Impacted Files Coverage Δ Complexity Δ
...java/org/mozilla/fenix/settings/SignOutFragment.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...a/org/mozilla/fenix/settings/TurnOnSyncFragment.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...la/fenix/components/metrics/GleanMetricsService.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...org/mozilla/fenix/components/BackgroundServices.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...va/org/mozilla/fenix/components/metrics/Metrics.kt 16.38% <0%> (+1.88%) 0 <0> (ø) ⬇️
...zilla/fenix/settings/DeleteBrowsingDataFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...fenix/components/metrics/LeanplumMetricsService.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...pp/src/main/java/org/mozilla/fenix/HomeActivity.kt 1.63% <0%> (-0.27%) 3 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67f3b63...8df4b38. Read the comment docs.

@boek
Copy link
Contributor

boek commented Aug 14, 2019

Data Review Form (to be filled by Data Stewards)

Instructions: Data Stewards will review a request for data collection and endorse responses to each question.

Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, with metrics.yaml, metrics.md and mma.md

Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, in the Fenix settings

If the request is for permanent data collection, is there someone who will monitor the data over time?
Has expiry, Fenix team will monitor

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
All data is category 1-2.

Is the data collection request for default-on or default-off?
Default on

Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No

Is the data collection covered by the existing Firefox privacy notice?
yes

Does there need to be a check-in in the future to determine whether to renew the data?
Has expiry. Fenix team will monitor

Does the data collection use a third-party collection tool?
No

"open" -> {
uri.getQueryParameter("url")?.let {
load(
searchTermOrURL = it,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do any type of sanitization on this url? cc: @colintheshots

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we already allow VIEW intents with potentially malicious site URLs or data URIs. The only change here is the schema is only recognized by our app currently and may load without asking first which app to use. However, there is no rule that another browser cannot also register fenix: and be annoying. It might be nice to use Android App Links to avoid contention over deep links with other apps. https://developer.android.com/training/app-links

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Created a follow up issue here: #4738

@boek boek added the needs:uplift Issue / PR needs to be uplifted to the release branch label Aug 14, 2019
@boek boek merged commit b7ca520 into mozilla-mobile:master Aug 14, 2019
ekager pushed a commit that referenced this pull request Aug 14, 2019
* For #4421: Adds Leanplum events and attributes

* For #4421: Adds Leanplum deep links
@ekager ekager removed the needs:uplift Issue / PR needs to be uplifted to the release branch label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs:data-review PR is awaiting a data review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants