For #4421: Adds Leanplum events and attributes #4626
Conversation
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
|
125e696
to
ce117b4
Compare
9de7871
to
058fca7
Compare
Codecov Report
@@ Coverage Diff @@
## master #4626 +/- ##
===========================================
- Coverage 6.41% 6.4% -0.01%
Complexity 154 154
===========================================
Files 205 205
Lines 8992 9005 +13
Branches 1321 1334 +13
===========================================
Hits 577 577
- Misses 8376 8389 +13
Partials 39 39
Continue to review full report at Codecov.
|
31cf0fb
to
6efdf84
Compare
Data Review Form (to be filled by Data Stewards) Instructions: Data Stewards will review a request for data collection and endorse responses to each question. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way? Is there a control mechanism that allows the user to turn the data collection on and off? If the request is for permanent data collection, is there someone who will monitor the data over time? Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? Is the data collection request for default-on or default-off? Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)? Is the data collection covered by the existing Firefox privacy notice? Does there need to be a check-in in the future to determine whether to renew the data? Does the data collection use a third-party collection tool? |
"open" -> { | ||
uri.getQueryParameter("url")?.let { | ||
load( | ||
searchTermOrURL = it, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we do any type of sanitization on this url? cc: @colintheshots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we already allow VIEW intents with potentially malicious site URLs or data URIs. The only change here is the schema is only recognized by our app currently and may load without asking first which app to use. However, there is no rule that another browser cannot also register fenix: and be annoying. It might be nice to use Android App Links to avoid contention over deep links with other apps. https://developer.android.com/training/app-links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Created a follow up issue here: #4738
Pull Request checklist