-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #4421: Add search widget attribute to Leanplum #4694
Conversation
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
|
Codecov Report
@@ Coverage Diff @@
## master #4694 +/- ##
===========================================
- Coverage 6.43% 6.4% -0.04%
Complexity 154 154
===========================================
Files 205 205
Lines 8969 8983 +14
Branches 1320 1321 +1
===========================================
- Hits 577 575 -2
- Misses 8353 8369 +16
Partials 39 39
Continue to review full report at Codecov.
|
Hey @jyeontaek could you add this items to the docs in this file https://github.com/mozilla-mobile/fenix/blob/master/docs/mma.md#user-attributes Another question: Do we want to add this to the glean core ping as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add documentation to mma.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Review Form (to be filled by Data Stewards)
Instructions: Data Stewards will review a request for data collection and endorse responses to each question.
-
Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, with mma.md -
Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, in the Fenix settings -
If the request is for permanent data collection, is there someone who will monitor the data over time?
Has expiry, Fenix team will monitor -
Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
All data is category 1. -
Is the data collection request for default-on or default-off?
Default on -
Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No -
Is the data collection covered by the existing Firefox privacy notice?
yes -
Does there need to be a check-in in the future to determine whether to renew the data?
Has expiry. Fenix team will monitor -
Does the data collection use a third-party collection tool?
No
Pull Request checklist