Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Clean up create collection view model and fragment #4731

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

NotWoods
Copy link
Contributor

Second attempt at #4274

  • CreateCollectionViewModel now just has state as a property, with setter functions. Long-term this logic could be moved into the store.
  • SaveCollectionStep is an enum. Code using the step has been simplified.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@NotWoods NotWoods requested a review from a team as a code owner August 14, 2019 16:44
@codecov-io
Copy link

codecov-io commented Aug 14, 2019

Codecov Report

Merging #4731 into master will increase coverage by 0.25%.
The diff coverage is 27.17%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #4731      +/-   ##
===========================================
+ Coverage      6.53%   6.79%   +0.25%     
- Complexity      151     160       +9     
===========================================
  Files           207     207              
  Lines          9029    8997      -32     
  Branches       1359    1346      -13     
===========================================
+ Hits            590     611      +21     
+ Misses         8394    8341      -53     
  Partials         45      45
Impacted Files Coverage Δ Complexity Δ
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...illa/fenix/collections/CollectionCreationUIView.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...lla/fenix/collections/SaveCollectionListAdapter.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...illa/fenix/collections/CreateCollectionFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...ix/collections/CollectionCreationTabListAdapter.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...a/fenix/collections/CollectionCreationComponent.kt 12.76% <30.76%> (+11.09%) 0 <0> (ø) ⬇️
...nix/components/toolbar/BrowserToolbarController.kt 92.94% <80%> (-0.17%) 0 <0> (ø)
...lla/fenix/collections/CreateCollectionViewModel.kt 94.73% <94.44%> (+94.73%) 9 <8> (+9) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8069610...01765a8. Read the comment docs.

@sblatz sblatz merged commit ac6c1ec into mozilla-mobile:master Aug 20, 2019
@NotWoods NotWoods deleted the create-collection branch January 25, 2020 19:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants