This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Ads 2 new tests to SearchTest #4770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sblatz
previously requested changes
Aug 16, 2019
There was a problem hiding this comment.
Looks pretty good! In addition to my comments, please run the pre-push hook on this and address the linting errors.
You can also use ktlint -F to fix most of them automatically.
app/src/androidTest/java/org/mozilla/fenix/ui/robots/TabsRobot.kt
Outdated
Show resolved
Hide resolved
rpappalax
reviewed
Aug 21, 2019
app/src/androidTest/java/org/mozilla/fenix/ui/robots/SearchRobot.kt
Outdated
Show resolved
Hide resolved
NotWoods
added
the
pr:needs-changes
sv-ohorvath
force-pushed
the
search-tests
branch
from
0d1ea4e
to
5b4adb1
Compare
Codecov Report
@@ Coverage Diff @@
## master #4770 +/- ##
=========================================
Coverage 11.91% 11.91%
Complexity 245 245
=========================================
Files 247 247
Lines 10231 10231
Branches 1511 1511
=========================================
Hits 1219 1219
Misses 8932 8932
Partials 80 80Continue to review full report at Codecov.
|
sv-ohorvath
added
pr:needs-review
and removed
pr:needs-changes
rpappalax
reviewed
Sep 11, 2019
rpappalax
approved these changes
Sep 11, 2019
|
@sv-ohorvath once @sblatz comments are addressed and the tests pass on Firebase, let me know and I will merge 👍 |
sv-ohorvath
force-pushed
the
search-tests
branch
from
5b4adb1
to
59d5eb4
Compare
|
@rpappalax I've run ktlint -F and the tests pass. This can be merged, thank you! |
sv-ohorvath
dismissed
sblatz’s stale review
ran the ktlint -F command automatically
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist