For #4421: Fixes issues with new glean events

[sblatz]

Pull Request checklist

• Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
• Tests: This PR includes thorough tests or an explanation of why it does not
• Changelog: This PR includes a changelog entry or does not need one
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

[sblatz]

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1. What questions will you answer with this data?

• How often users sign up for a new FxA account within Fenix

2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?

• To measure how many new users to FxA we're gaining through Fenix.

3. What alternative methods did you consider to answer these questions? Why were they not sufficient?

• N/A

4. Can current instrumentation answer these questions?

• We are sending this metric to Leanplum but not Glean. We have events for sign in / sign out, but not distinguishing between new users or returning ones.

5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.

• All data is Category 2.

6. How long will this data be collected?

Until 03/01/2020

7. What populations will you measure?

• All release, beta, and nightly users with telemetry enabled.

8. Please provide a general description of how you will analyze this data.

• Glean / Amplitude

9. Where do you intend to share the results of your analysis?

• Only on Glean, Amplitude and with mobile teams.

[codecov-io]

Codecov Report

Merging #4816 into master will decrease coverage by 0.17%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #4816      +/-   ##
===========================================
- Coverage      6.53%   6.36%   -0.18%     
- Complexity      151     154       +3     
===========================================
  Files           207     205       -2     
  Lines          9024    9024              
  Branches       1357    1359       +2     
===========================================
- Hits            590     574      -16     
- Misses         8389    8404      +15     
- Partials         45      46       +1

Impacted Files	Coverage Δ	Complexity Δ
...illa/fenix/collections/CreateCollectionFragment.kt	0% <0%> (ø)	0 <0> (ø)	⬇️
...la/fenix/components/metrics/GleanMetricsService.kt	0% <0%> (ø)	0 <0> (ø)	⬇️
app/src/main/java/org/mozilla/fenix/ext/Context.kt	12% <0%> (-8%)	0% <0%> (ø)
...ozilla/fenix/library/bookmarks/BookmarkFragment.kt	0% <0%> (ø)	0% <0%> (ø)	⬇️
...g/mozilla/fenix/settings/DeleteBrowsingDataItem.kt	0% <0%> (ø)	0% <0%> (ø)	⬇️
...a/org/mozilla/fenix/browser/BaseBrowserFragment.kt	0% <0%> (ø)	0% <0%> (ø)	⬇️
.../java/org/mozilla/fenix/browser/BrowserFragment.kt	0% <0%> (ø)	0% <0%> (ø)	⬇️
...x/settings/quicksettings/QuickSettingsComponent.kt	0% <0%> (ø)	0% <0%> (ø)	⬇️
...src/main/java/org/mozilla/fenix/components/Core.kt	0% <0%> (ø)	0% <0%> (ø)	⬇️
...main/java/org/mozilla/fenix/settings/Extensions.kt	0% <0%> (ø)	0% <0%> (ø)	⬇️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae05bf9...57ebed5. Read the comment docs.

[boek]

Data Review Form (to be filled by Data Stewards)

Instructions: Data Stewards will review a request for data collection and endorse responses to each question.

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
   Yes, with metrics.yaml and metrics.md

2. Is there a control mechanism that allows the user to turn the data collection on and off?
   Yes, in the Fenix settings

3. If the request is for permanent data collection, is there someone who will monitor the data over time?
   Has expiry, Fenix team will monitor

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
   All data is category 2.

5. Is the data collection request for default-on or default-off?
   Default on

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
   No

7. Is the data collection covered by the existing Firefox privacy notice?
   yes

8. Does there need to be a check-in in the future to determine whether to renew the data?
   Has expiry. Fenix team will monitor

9. Does the data collection use a third-party collection tool?
   No