Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #419: Create shortcuts for private browsing #4948

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

jyeontaek
Copy link
Contributor

@jyeontaek jyeontaek commented Aug 27, 2019

This PR consists of three PBM features:

  1. Long press shortcuts

Screen Shot 2019-09-11 at 10 57 18 AM

  1. Adding pinned shortcuts

Screen Shot 2019-09-11 at 10 59 27 AM

  1. Contextual feature recommender for pinned shortcuts

Screen Shot 2019-09-11 at 10 30 15 AM

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@jyeontaek jyeontaek requested a review from a team as a code owner August 27, 2019 17:12
app/src/main/AndroidManifest.xml Show resolved Hide resolved
app/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
app/src/main/res/values/static_strings.xml Outdated Show resolved Hide resolved
@NotWoods NotWoods added the pr:needs-changes PRs that need some changes/fixes before they can land label Aug 30, 2019
@jyeontaek jyeontaek requested a review from a team as a code owner August 30, 2019 23:28
@codecov-io
Copy link

codecov-io commented Sep 5, 2019

Codecov Report

Merging #4948 into master will decrease coverage by 2.2%.
The diff coverage is 7.77%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #4948      +/-   ##
===========================================
- Coverage     11.61%   9.41%   -2.21%     
+ Complexity      238     206      -32     
===========================================
  Files           243     236       -7     
  Lines          9828    9335     -493     
  Branches       1425    1349      -76     
===========================================
- Hits           1142     879     -263     
+ Misses         8616    8396     -220     
+ Partials         70      60      -10
Impacted Files Coverage Δ Complexity Δ
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...ava/org/mozilla/fenix/settings/SettingsFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...n/java/org/mozilla/fenix/IntentReceiverActivity.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...a/fenix/components/PrivateShortcutCreateManager.kt 0% <0%> (ø) 0 <0> (?)
...a/org/mozilla/fenix/widget/SearchWidgetProvider.kt 1.33% <0%> (ø) 1 <0> (ø) ⬇️
...pp/src/main/java/org/mozilla/fenix/HomeActivity.kt 7.46% <0%> (-0.23%) 7 <0> (ø)
.../src/main/java/org/mozilla/fenix/utils/Settings.kt 71.55% <17.64%> (-5.18%) 15 <0> (+5)
...la/fenix/home/intent/StartSearchIntentProcessor.kt 90% <80%> (-10%) 4 <3> (ø)
...n/java/org/mozilla/fenix/FenixViewModelProvider.kt 0% <0%> (-100%) 0% <0%> (-2%)
app/src/main/java/org/mozilla/fenix/ext/View.kt 0% <0%> (-100%) 0% <0%> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9033b8d...80b03cb. Read the comment docs.

@jyeontaek jyeontaek force-pushed the issue_419 branch 4 times, most recently from b3391c7 to a770b7c Compare September 10, 2019 00:01
@jyeontaek jyeontaek changed the title For #419: Create launch icon for private browsing For #419: Create shortcuts for private browsing Sep 10, 2019
Copy link
Contributor

@NotWoods NotWoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but I need to test on my device later. Semi-approved right now :)

Copy link
Contributor

@NotWoods NotWoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @sblatz please also take a look

@jyeontaek jyeontaek added this to the v2.0 milestone Sep 11, 2019
@jyeontaek jyeontaek merged commit 2e2bac4 into mozilla-mobile:master Sep 11, 2019
@jyeontaek jyeontaek added eng:qa:needed QA Needed and removed pr:needs-changes PRs that need some changes/fixes before they can land eng:qa:needed QA Needed labels Sep 11, 2019
@jyeontaek jyeontaek removed this from the v2.0 milestone Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants