This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #419: Create shortcuts for private browsing #4948
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotWoods
suggested changes
Aug 27, 2019
app/src/main/res/drawable-v24/ic_launcher_private_foreground.xml
Outdated
Show resolved
Hide resolved
NotWoods
added
the
pr:needs-changes
PRs that need some changes/fixes before they can land
label
Aug 30, 2019
Codecov Report
@@ Coverage Diff @@
## master #4948 +/- ##
===========================================
- Coverage 11.61% 9.41% -2.21%
+ Complexity 238 206 -32
===========================================
Files 243 236 -7
Lines 9828 9335 -493
Branches 1425 1349 -76
===========================================
- Hits 1142 879 -263
+ Misses 8616 8396 -220
+ Partials 70 60 -10
Continue to review full report at Codecov.
|
NotWoods
reviewed
Sep 9, 2019
app/src/main/java/org/mozilla/fenix/components/ShortcutUtilities.kt
Outdated
Show resolved
Hide resolved
jyeontaek
force-pushed
the
issue_419
branch
4 times, most recently
from
September 10, 2019 00:01
b3391c7
to
a770b7c
Compare
jyeontaek
changed the title
For #419: Create launch icon for private browsing
For #419: Create shortcuts for private browsing
Sep 10, 2019
NotWoods
reviewed
Sep 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good but I need to test on my device later. Semi-approved right now :)
app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/home/intent/StartSearchIntentProcessor.kt
Show resolved
Hide resolved
NotWoods
approved these changes
Sep 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @sblatz please also take a look
ekager
reviewed
Sep 10, 2019
app/src/main/java/org/mozilla/fenix/components/PrivateShortcutCreateManager.kt
Show resolved
Hide resolved
ekager
reviewed
Sep 10, 2019
app/src/main/java/org/mozilla/fenix/components/PrivateShortcutCreateManager.kt
Outdated
Show resolved
Hide resolved
ekager
reviewed
Sep 10, 2019
ekager
reviewed
Sep 10, 2019
sblatz
reviewed
Sep 10, 2019
app/src/main/java/org/mozilla/fenix/components/PrivateShortcutCreateManager.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/components/PrivateShortcutCreateManager.kt
Show resolved
Hide resolved
jyeontaek
force-pushed
the
issue_419
branch
from
September 11, 2019 17:38
fc2f0e2
to
80b03cb
Compare
jyeontaek
added
eng:qa:needed
QA Needed
and removed
pr:needs-changes
PRs that need some changes/fixes before they can land
eng:qa:needed
QA Needed
labels
Sep 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of three PBM features:
Pull Request checklist