This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
History management #497
Merged
History management #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
boek
force-pushed
the
i357-history_management
branch
from
4a27c1f
to
43d6abd
Compare
boek
commented
Feb 15, 2019
boek
commented
Feb 15, 2019
colintheshots
previously requested changes
Feb 15, 2019
app/src/main/java/org/mozilla/fenix/library/history/HistoryFragment.kt
Outdated
Show resolved
Hide resolved
… the right value
…of items selected
boek
force-pushed
the
i357-history_management
branch
from
745352a
to
5a6a9d6
Compare
|
@colintheshots I also want to add some tests, but I'm not sure how to scaffold that up. Once you add the first one I'll open a new PR to add some to this 👍 |
ekager
approved these changes
Feb 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.