Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #4969: Removes erroneous FxA sign up ping #4970

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Aug 27, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@sblatz sblatz requested a review from a team as a code owner August 27, 2019 23:43
@codecov-io
Copy link

Codecov Report

Merging #4970 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #4970      +/-   ##
===========================================
+ Coverage      8.08%   8.08%   +<.01%     
  Complexity      176     176              
===========================================
  Files           222     222              
  Lines          9017    9012       -5     
  Branches       1320    1318       -2     
===========================================
  Hits            729     729              
+ Misses         8236    8231       -5     
  Partials         52      52
Impacted Files Coverage Δ Complexity Δ
...la/fenix/components/metrics/GleanMetricsService.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...org/mozilla/fenix/components/BackgroundServices.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...va/org/mozilla/fenix/components/metrics/Metrics.kt 18.75% <ø> (+0.1%) 0 <0> (ø) ⬇️
...fenix/components/metrics/LeanplumMetricsService.kt 0% <ø> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 681257b...cdf9466. Read the comment docs.

@ekager ekager requested a review from boek August 28, 2019 17:50
@ekager
Copy link
Contributor

ekager commented Aug 28, 2019

CC @boek because you know much more than I do about where things need to be added/removed for telemetry

@boek boek merged commit 09ed721 into mozilla-mobile:master Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants