Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #5021: Adds metric for what's new button #5090

Merged
merged 1 commit into from Sep 4, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Sep 3, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

This PR does not need tests because it's just a telemetry metric addition

@sblatz sblatz requested review from a team as code owners September 3, 2019 17:03
@sblatz sblatz changed the title For #5021: Adds telemetry for what's new button For #5021: Adds metric for what's new button Sep 3, 2019
@sblatz
Copy link
Contributor Author

sblatz commented Sep 3, 2019

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • How often users tap "what's new" from either the settings menu or the about page
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • To measure how often users interact with the what's new button to get information about our updates to Fenix.
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • N/A (These are baseline metrics)
  1. Can current instrumentation answer these questions?
  • Currently there are no events to track this what's new button
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
  • All data is Category 2.
  1. How long will this data be collected?

Until 03/01/2020

  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled.
  1. Please provide a general description of how you will analyze this data.
  • Glean / Amplitude
  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude and with mobile teams.

@sblatz sblatz requested a review from boek September 3, 2019 17:37
@sblatz sblatz added the needs:data-review PR is awaiting a data review label Sep 3, 2019
@codecov-io
Copy link

codecov-io commented Sep 3, 2019

Codecov Report

Merging #5090 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #5090      +/-   ##
===========================================
- Coverage      8.87%   8.71%   -0.16%     
+ Complexity      195     192       -3     
===========================================
  Files           234     231       -3     
  Lines          9226    9142      -84     
  Branches       1332    1326       -6     
===========================================
- Hits            819     797      -22     
+ Misses         8353    8292      -61     
+ Partials         54      53       -1
Impacted Files Coverage Δ Complexity Δ
...in/java/org/mozilla/fenix/share/ShareController.kt 79.31% <0%> (-1.46%) 0% <0%> (ø)
...main/java/org/mozilla/fenix/share/ShareFragment.kt 1.53% <0%> (ø) 0% <0%> (ø) ⬇️
...n/java/org/mozilla/fenix/settings/AboutFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...p/src/main/java/org/mozilla/fenix/home/HomeMenu.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...in/java/org/mozilla/fenix/settings/SupportUtils.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...rc/main/java/org/mozilla/fenix/BrowserDirection.kt 100% <0%> (ø) 2% <0%> (ø) ⬇️
...nix/components/toolbar/BrowserToolbarController.kt 92.13% <0%> (ø) 0% <0%> (ø) ⬇️
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...a/fenix/components/toolbar/BrowserFragmentStore.kt
...java/org/mozilla/fenix/whatsnew/WhatsNewVersion.kt
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e54414...c91cd8b. Read the comment docs.

Copy link
Contributor

@boek boek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Review Form (to be filled by Data Stewards)

Instructions: Data Stewards will review a request for data collection and endorse responses to each question.

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
    Yes, with metrics.yaml and metrics.md

  2. Is there a control mechanism that allows the user to turn the data collection on and off?
    Yes, in the Fenix settings

  3. If the request is for permanent data collection, is there someone who will monitor the data over time?
    Has expiry, Fenix team will monitor

  4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
    All data is category 2.

  5. Is the data collection request for default-on or default-off?
    Default on

  6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
    No

  7. Is the data collection covered by the existing Firefox privacy notice?
    yes

  8. Does there need to be a check-in in the future to determine whether to renew the data?
    Has expiry. Fenix team will monitor

  9. Does the data collection use a third-party collection tool?
    No

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs:data-review PR is awaiting a data review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants