-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #3371 Show snackbar message when share fails with crash #5210
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5210 +/- ##
============================================
+ Coverage 11.36% 11.36% +<.01%
Complexity 232 232
============================================
Files 235 235
Lines 9265 9271 +6
Branches 1338 1339 +1
============================================
+ Hits 1053 1054 +1
- Misses 8144 8149 +5
Partials 68 68
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #5210 +/- ##
============================================
- Coverage 11.74% 11.36% -0.38%
+ Complexity 245 232 -13
============================================
Files 247 235 -12
Lines 10195 9271 -924
Branches 1505 1339 -166
============================================
- Hits 1197 1054 -143
+ Misses 8923 8149 -774
+ Partials 75 68 -7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good! Though, we should land this after we cut the release because the string deadline already passed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Fix the nits and let's land it.
…rash Caught SecurityException and show message that sharing to that app failed Added share_error_snackbar string
Caught SecurityException and show message that sharing to that app failed
Added share_error_snackbar string
Pull Request checklist
After merge