Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #3371 Show snackbar message when share fails with crash #5210

Merged
merged 1 commit into from
Sep 12, 2019

Conversation

mcarare
Copy link
Contributor

@mcarare mcarare commented Sep 11, 2019

Caught SecurityException and show message that sharing to that app failed
Added share_error_snackbar string

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

@mcarare mcarare requested review from a team as code owners September 11, 2019 12:08
@codecov-io
Copy link

Codecov Report

Merging #5210 into master will increase coverage by <.01%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5210      +/-   ##
============================================
+ Coverage     11.36%   11.36%   +<.01%     
  Complexity      232      232              
============================================
  Files           235      235              
  Lines          9265     9271       +6     
  Branches       1338     1339       +1     
============================================
+ Hits           1053     1054       +1     
- Misses         8144     8149       +5     
  Partials         68       68
Impacted Files Coverage Δ Complexity Δ
...in/java/org/mozilla/fenix/share/ShareController.kt 70.58% <28.57%> (-11.56%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e83edc...cba71b1. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Sep 11, 2019

Codecov Report

Merging #5210 into master will decrease coverage by 0.37%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5210      +/-   ##
============================================
- Coverage     11.74%   11.36%   -0.38%     
+ Complexity      245      232      -13     
============================================
  Files           247      235      -12     
  Lines         10195     9271     -924     
  Branches       1505     1339     -166     
============================================
- Hits           1197     1054     -143     
+ Misses         8923     8149     -774     
+ Partials         75       68       -7
Impacted Files Coverage Δ Complexity Δ
...in/java/org/mozilla/fenix/share/ShareController.kt 70.58% <28.57%> (-13.29%) 0 <0> (ø)
...pp/src/main/java/org/mozilla/fenix/FeatureFlags.kt 87.5% <0%> (-2.5%) 2% <0%> (ø)
...illa/fenix/components/toolbar/BrowserInteractor.kt 95.23% <0%> (-0.42%) 11% <0%> (ø)
...rg/mozilla/fenix/components/toolbar/ToolbarMenu.kt 94.11% <0%> (-0.33%) 0% <0%> (ø)
...lla/fenix/components/toolbar/BrowserToolbarView.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ngs/quicksettings/TrackingProtectionSettingView.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...g/mozilla/fenix/settings/DeleteBrowsingDataItem.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...n/java/org/mozilla/fenix/IntentReceiverActivity.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...in/java/org/mozilla/fenix/search/SearchFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5859e0...09cd735. Read the comment docs.

Copy link
Contributor

@jyeontaek jyeontaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! Though, we should land this after we cut the release because the string deadline already passed.

Copy link
Contributor

@colintheshots colintheshots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Fix the nits and let's land it.

…rash

Caught SecurityException and show message that sharing to that app failed
Added share_error_snackbar string
@jyeontaek jyeontaek merged commit bc16061 into mozilla-mobile:master Sep 12, 2019
@mcarare mcarare deleted the 3371 branch October 28, 2019 08:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants