Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

fix TabbedBrowsingTest.kt failure where Share Tabs element was not found #5282

Merged
merged 1 commit into from
Sep 12, 2019
Merged

fix TabbedBrowsingTest.kt failure where Share Tabs element was not found #5282

merged 1 commit into from
Sep 12, 2019

Conversation

nojunpark
Copy link

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

@nojunpark nojunpark requested review from a team as code owners September 12, 2019 22:40
@codecov-io
Copy link

Codecov Report

Merging #5282 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5282      +/-   ##
============================================
+ Coverage     11.91%   11.93%   +0.02%     
  Complexity      245      245              
============================================
  Files           247      247              
  Lines         10231    10213      -18     
  Branches       1511     1507       -4     
============================================
  Hits           1219     1219              
+ Misses         8932     8914      -18     
  Partials         80       80
Impacted Files Coverage Δ Complexity Δ
.../java/org/mozilla/fenix/library/LibraryPageView.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...a/org/mozilla/fenix/library/history/HistoryView.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...lla/fenix/components/toolbar/BrowserToolbarView.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...rg/mozilla/fenix/library/bookmarks/BookmarkView.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../bookmarks/viewholders/BookmarkFolderViewHolder.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ry/bookmarks/viewholders/BookmarkItemViewHolder.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fda140...94e38cb. Read the comment docs.

@rpappalax rpappalax merged commit 3cdcbe4 into mozilla-mobile:master Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants