-
Notifications
You must be signed in to change notification settings - Fork 1.3k
No issue: Update long-press shortcut strings #5284
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5284 +/- ##
============================================
- Coverage 13.24% 12.73% -0.52%
+ Complexity 289 277 -12
============================================
Files 253 251 -2
Lines 10404 10326 -78
Branches 1514 1502 -12
============================================
- Hits 1378 1315 -63
+ Misses 8932 8922 -10
+ Partials 94 89 -5
Continue to review full report at Codecov.
|
app/src/main/res/values/strings.xml
Outdated
@@ -42,9 +42,9 @@ | |||
|
|||
<!-- Home screen icons - Long press shortcuts --> | |||
<!-- Shortcut action to open new tab --> | |||
<string name="home_screen_shortcut_open_new_tab">Open new tab</string> | |||
<string name="home_screen_shortcut_open_new_tab">New tab</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How long has this string been landed for? To be safe, you probably need to update the resource name of this string, because it will already have been translated by L10N. Changing strings requires a new resource name so it gets picked up by Pontoon, and localizers see it as a new string to be localized.
@Delphine just to check, that's still necessary with the a10n localization Fenix is using, right?
home_screen_shortcut_open_new_tab2
or something like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This string got landed last week Tuesday.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay got an answer in #fenix-team, yes we still do need to update the resource ids.
6c0a4ec
to
46955b8
Compare
46955b8
to
bc9f10e
Compare
Remember we shouldn't be landing new strings at this point in the sprint. We should punt landing this to after we cut next release? |
* No issue: Update long-press shortcut strings * Updates identifiers
* No issue: Update long-press shortcut strings * Updates identifiers
We're updating the strings by request of @apbitner
Pull Request checklist
After merge