Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Extract current mode from home fragment #5343

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

NotWoods
Copy link
Contributor

Pulls out the function for getting the current mode and emitting when it changes. Long-term this should probably be moved to some state for the home fragment.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

@NotWoods NotWoods requested review from a team as code owners September 15, 2019 18:49
@codecov-io
Copy link

codecov-io commented Sep 15, 2019

Codecov Report

Merging #5343 into master will increase coverage by 0.24%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5343      +/-   ##
============================================
+ Coverage     12.89%   13.14%   +0.24%     
  Complexity      283      283              
============================================
  Files           252      253       +1     
  Lines         10362    10363       +1     
  Branches       1504     1506       +2     
============================================
+ Hits           1336     1362      +26     
+ Misses         8936     8911      -25     
  Partials         90       90
Impacted Files Coverage Δ Complexity Δ
...nix/home/sessioncontrol/SessionControlComponent.kt 1.35% <ø> (+1.35%) 0 <0> (ø) ⬇️
.../fenix/home/sessioncontrol/SessionControlUIView.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...fenix/home/sessioncontrol/SessionControlAdapter.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
app/src/main/java/org/mozilla/fenix/home/Mode.kt 100% <100%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a6e647...6cff44d. Read the comment docs.

Copy link
Contributor

@sblatz sblatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested:

  • Onboarding gets dismissed properly
  • Onboarding updates correctly based on account login
  • Private mode switching works

Looks good, thanks for all the tests!!

@sblatz sblatz merged commit cb77015 into mozilla-mobile:master Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants