Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #5369 - Bug 1577479 - Fix push() call in old decision task #5373

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

JohanLorenzo
Copy link
Contributor

@JohanLorenzo JohanLorenzo commented Sep 17, 2019

The regression was introduced in #5011 because of a late merge conflict and an overlook of mine in the review.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

@JohanLorenzo JohanLorenzo requested review from a team as code owners September 17, 2019 05:41
@codecov-io
Copy link

codecov-io commented Sep 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@2b71af4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5373   +/-   ##
=========================================
  Coverage          ?   12.54%           
  Complexity        ?      258           
=========================================
  Files             ?      248           
  Lines             ?    10295           
  Branches          ?     1520           
=========================================
  Hits              ?     1292           
  Misses            ?     8914           
  Partials          ?       89

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b71af4...a2dcb55. Read the comment docs.

@JohanLorenzo JohanLorenzo merged commit 25db27e into master Sep 17, 2019
@JohanLorenzo JohanLorenzo deleted the fix-5369 branch September 17, 2019 10:10
@JohanLorenzo JohanLorenzo changed the title For #5369 - Fix push() call in old decision task For #5369 - Bug 1577479 - Fix push() call in old decision task Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants