Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #5406: Ignore intermittent failing test temporarily #5485

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

jonalmeida
Copy link
Contributor

While #5406 is being investigated, we can disable the test to pass automation and nightly builds.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-io
Copy link

codecov-io commented Sep 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@cb77015). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5485   +/-   ##
=========================================
  Coverage          ?   13.24%           
  Complexity        ?      289           
=========================================
  Files             ?      253           
  Lines             ?    10404           
  Branches          ?     1514           
=========================================
  Hits              ?     1378           
  Misses            ?     8932           
  Partials          ?       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb77015...68a7abb. Read the comment docs.

@colintheshots
Copy link
Contributor

Looks like there's a merge conflict. Could you please rebase?

@jonalmeida
Copy link
Contributor Author

@colintheshots done!

@ekager ekager merged commit 612b0fc into mozilla-mobile:master Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants