Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Bug 1580778 - Migrate build tasks to taskgraph and retire the old dec… #5488

Merged

Conversation

JohanLorenzo
Copy link
Contributor

…ision task

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@JohanLorenzo JohanLorenzo requested review from a team as code owners September 23, 2019 15:24
@JohanLorenzo JohanLorenzo force-pushed the migrate-build-tasks branch 3 times, most recently from b0f6204 to befe52f Compare September 23, 2019 16:28
@JohanLorenzo JohanLorenzo added the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Sep 23, 2019
@JohanLorenzo JohanLorenzo force-pushed the migrate-build-tasks branch 2 times, most recently from 0e7952a to 7ef6983 Compare September 23, 2019 17:17
@codecov-io
Copy link

codecov-io commented Sep 23, 2019

Codecov Report

Merging #5488 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5488   +/-   ##
=========================================
  Coverage     13.24%   13.24%           
  Complexity      289      289           
=========================================
  Files           253      253           
  Lines         10404    10404           
  Branches       1514     1514           
=========================================
  Hits           1378     1378           
  Misses         8932     8932           
  Partials         94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c55aff...8175e89. Read the comment docs.

run-on-tasks-for: []
# Builds generate multiple APKs with different ABIs. For each APK described
# by `gradlew printVariant`, an artifact will be generated. `variant` and
# the per-apk config from `printVariant` can be used as subsistutions in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

substitutions* :)
Thanks for documenting which properties have variables available :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I intend to change the gradle call because it slowed down the decision task run. The reason is: taskgraph generates all tasks (before filtering them out), so we have about 8 call to gradle, which is slower than before. I think I'll replace it with a single call to gradle which outputs config.

Edit: typo fixed!

@JohanLorenzo JohanLorenzo removed the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Sep 24, 2019
@JohanLorenzo
Copy link
Contributor Author

taskcluster/fenix_taskgraph/util.py Show resolved Hide resolved
@JohanLorenzo JohanLorenzo merged commit 6a8f722 into mozilla-mobile:master Sep 24, 2019
@JohanLorenzo JohanLorenzo deleted the migrate-build-tasks branch September 24, 2019 10:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants