-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Bug 1580778 - Migrate build tasks to taskgraph and retire the old dec… #5488
Bug 1580778 - Migrate build tasks to taskgraph and retire the old dec… #5488
Conversation
b0f6204
to
befe52f
Compare
0e7952a
to
7ef6983
Compare
Codecov Report
@@ Coverage Diff @@
## master #5488 +/- ##
=========================================
Coverage 13.24% 13.24%
Complexity 289 289
=========================================
Files 253 253
Lines 10404 10404
Branches 1514 1514
=========================================
Hits 1378 1378
Misses 8932 8932
Partials 94 94 Continue to review full report at Codecov.
|
taskcluster/ci/build/kind.yml
Outdated
run-on-tasks-for: [] | ||
# Builds generate multiple APKs with different ABIs. For each APK described | ||
# by `gradlew printVariant`, an artifact will be generated. `variant` and | ||
# the per-apk config from `printVariant` can be used as subsistutions in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
substitutions* :)
Thanks for documenting which properties have variables available :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I intend to change the gradle call because it slowed down the decision task run. The reason is: taskgraph generates all tasks (before filtering them out), so we have about 8 call to gradle, which is slower than before. I think I'll replace it with a single call to gradle which outputs config.
Edit: typo fixed!
Tested against:
The push-apk failures are due to worker configuration. I made sure the push-apk payloads haven't changed. |
7ef6983
to
8175e89
Compare
…ision task
Pull Request checklist
After merge
To download an APK when reviewing a PR: