Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Closes #4711 - Extract VoiceSearchActivity #5502

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

NotWoods
Copy link
Contributor

This moves the voice search specific code out of IntentReceiverActivity and into its own class.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@NotWoods NotWoods requested review from a team as code owners September 24, 2019 02:03
@codecov-io
Copy link

codecov-io commented Sep 24, 2019

Codecov Report

Merging #5502 into master will increase coverage by 0.12%.
The diff coverage is 72.22%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5502      +/-   ##
============================================
+ Coverage     14.05%   14.18%   +0.12%     
- Complexity      308      316       +8     
============================================
  Files           256      257       +1     
  Lines         10495    10498       +3     
  Branches       1522     1523       +1     
============================================
+ Hits           1475     1489      +14     
+ Misses         8903     8888      -15     
- Partials        117      121       +4
Impacted Files Coverage Δ Complexity Δ
...a/org/mozilla/fenix/widget/SearchWidgetProvider.kt 1.36% <0%> (+0.03%) 1 <0> (ø) ⬇️
...nix/home/intent/SpeechProcessingIntentProcessor.kt 100% <100%> (ø) 5 <0> (ø) ⬇️
...n/java/org/mozilla/fenix/IntentReceiverActivity.kt 34.14% <100%> (+0.81%) 4 <0> (-2) ⬇️
...va/org/mozilla/fenix/widget/VoiceSearchActivity.kt 77.77% <77.77%> (ø) 10 <10> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dffa61b...197bdbc. Read the comment docs.

@sblatz sblatz self-assigned this Sep 26, 2019
Copy link
Contributor

@sblatz sblatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me 😄

@NotWoods NotWoods added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Sep 26, 2019
@sblatz
Copy link
Contributor

sblatz commented Sep 26, 2019

Rebasing master to see if that fixes the UI test issue.

@sblatz sblatz merged commit 88aa519 into mozilla-mobile:master Sep 27, 2019
sblatz pushed a commit to sblatz/fenix that referenced this pull request Sep 30, 2019
sblatz pushed a commit to sblatz/fenix that referenced this pull request Sep 30, 2019
@NotWoods NotWoods deleted the voice-search-activity branch January 25, 2020 19:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:health Improve code health feature:SearchWidget pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants