Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #4991:Ensured deleteSelectedBookmarks deletes all selected bookmarks #5559

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

mcarare
Copy link
Contributor

@mcarare mcarare commented Sep 25, 2019

Moved the deletion to a CoroutineScope(IO) to decouple from fragment lifecycle
Used local val tempStorage to keep reference to bookmarkStorage of outside class
Ran deletions with awaitAll to avoid concurrency issues on storage

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

…elected bookmarks

Moved the deletion to a CoroutineScope(IO) to decouple from fragment lifecycle
Used local val tempStorage to keep reference to bookmarkStorage of outside class
Ran deletions with awaitAll to avoid concurrency issues on storage
@mcarare mcarare requested review from a team as code owners September 25, 2019 09:50
@codecov-io
Copy link

codecov-io commented Sep 25, 2019

Codecov Report

Merging #5559 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5559      +/-   ##
============================================
- Coverage     14.04%   14.04%   -0.01%     
  Complexity      311      311              
============================================
  Files           255      255              
  Lines         10414    10418       +4     
  Branches       1507     1508       +1     
============================================
  Hits           1463     1463              
- Misses         8840     8844       +4     
  Partials        111      111
Impacted Files Coverage Δ Complexity Δ
...ozilla/fenix/library/bookmarks/BookmarkFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...va/org/mozilla/fenix/onboarding/FenixOnboarding.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...g/mozilla/fenix/crashes/CrashReporterController.kt 94.11% <0%> (ø) 6% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c9c531...f6c9972. Read the comment docs.

Copy link
Contributor

@sblatz sblatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sblatz sblatz merged commit 62ae025 into mozilla-mobile:master Sep 26, 2019
sblatz pushed a commit to sblatz/fenix that referenced this pull request Sep 30, 2019
…elected bookmarks (mozilla-mobile#5559)

Moved the deletion to a CoroutineScope(IO) to decouple from fragment lifecycle
Used local val tempStorage to keep reference to bookmarkStorage of outside class
Ran deletions with awaitAll to avoid concurrency issues on storage
sblatz pushed a commit to sblatz/fenix that referenced this pull request Sep 30, 2019
…elected bookmarks (mozilla-mobile#5559)

Moved the deletion to a CoroutineScope(IO) to decouple from fragment lifecycle
Used local val tempStorage to keep reference to bookmarkStorage of outside class
Ran deletions with awaitAll to avoid concurrency issues on storage
@mcarare mcarare deleted the bk-del2 branch October 28, 2019 08:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants