This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #5567: Removes search shortcuts button #5739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sblatz
changed the title
|
@brampitoyo please verify this matches your expected mocks :) |
sblatz
force-pushed
the
remove-shortcuts-button
branch
2 times, most recently
from
3a339e0
to
ea273ee
Compare
Codecov Report
@@ Coverage Diff @@
## master #5739 +/- ##
============================================
- Coverage 14.46% 14.45% -0.01%
- Complexity 322 323 +1
============================================
Files 255 256 +1
Lines 10490 10505 +15
Branches 1526 1529 +3
============================================
+ Hits 1517 1519 +2
- Misses 8851 8864 +13
Partials 122 122
Continue to review full report at Codecov.
|
sblatz
force-pushed
the
remove-shortcuts-button
branch
from
ea273ee
to
1f68e05
Compare
brampitoyo
approved these changes
Oct 2, 2019
There was a problem hiding this comment.
@sblatz This looks good! Thanks for suggesting an awesome, easy to build idea that solves our problem.
liuche
reviewed
Oct 3, 2019
| searchStore.dispatch(SearchFragmentAction.ShowSearchShortcutEnginePicker(!isOpen)) | ||
|
|
||
| if (isOpen) { | ||
| requireComponents.analytics.metrics.track(Event.SearchShortcutMenuClosed) |
There was a problem hiding this comment.
Can we remove these telemetry items? (Should not using these events break the build on telemetry?)
| android:id="@+id/searchShortcutsButton" | ||
| style="@style/search_pill" | ||
| android:drawableStart="@drawable/ic_search" | ||
| android:textOff="@string/search_shortcuts_button" |
sblatz
force-pushed
the
remove-shortcuts-button
branch
from
1f68e05
to
73fad7c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge
To download an APK when reviewing a PR: