Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

No issue: fixes master #5777

Merged
merged 1 commit into from
Oct 3, 2019
Merged

No issue: fixes master #5777

merged 1 commit into from
Oct 3, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Oct 3, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sblatz sblatz requested a review from a team October 3, 2019 20:42
@codecov-io
Copy link

codecov-io commented Oct 3, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@371e2ac). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5777   +/-   ##
=========================================
  Coverage          ?   14.43%           
  Complexity        ?      324           
=========================================
  Files             ?      256           
  Lines             ?    10507           
  Branches          ?     1530           
=========================================
  Hits              ?     1517           
  Misses            ?     8864           
  Partials          ?      126
Impacted Files Coverage Δ Complexity Δ
...n/java/org/mozilla/fenix/IntentReceiverActivity.kt 29.16% <ø> (ø) 4 <0> (?)
...rc/main/java/org/mozilla/fenix/FenixApplication.kt 4.5% <100%> (ø) 4 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 371e2ac...bfbe285. Read the comment docs.

@sblatz sblatz merged commit 841b06b into mozilla-mobile:master Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants