Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Closes #5382: Adds bors toml #5899

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Closes #5382: Adds bors toml #5899

merged 1 commit into from
Oct 10, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Oct 9, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sblatz sblatz requested a review from a team October 9, 2019 18:49
@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #5899 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5899      +/-   ##
============================================
+ Coverage      14.3%   14.31%   +0.01%     
  Complexity      320      320              
============================================
  Files           257      257              
  Lines         10622    10624       +2     
  Branches       1553     1553              
============================================
+ Hits           1519     1521       +2     
  Misses         8977     8977              
  Partials        126      126
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/org/mozilla/fenix/BrowserDirection.kt 100% <0%> (ø) 2% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9afd97...a1c7055. Read the comment docs.

@sblatz sblatz merged commit 46ddfd0 into mozilla-mobile:master Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants