This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #6063 - ETP blocking info title new strings #6082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6082 +/- ##
============================================
- Coverage 14.29% 14.29% -0.01%
Complexity 324 324
============================================
Files 259 259
Lines 10700 10702 +2
Branches 1560 1559 -1
============================================
Hits 1530 1530
- Misses 9045 9047 +2
Partials 125 125
Continue to review full report at Codecov.
|
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 19, 2019
6017: For #6011 - fixed truncated clipboard icon in RTL r=ekager a=cadeyrn  6082: For #6063 - ETP blocking info title new strings r=ekager a=BranescuMihai ### Pull Request checklist <!-- Before submitting the PR, please address each item --> - [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended) - [x] **Tests**: Only string change, no tests - [x] **Screenshots**: This PR includes screenshots - [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) ### After merge - [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development. ### To download an APK when reviewing a PR: 1. click on Show All Checks, 2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark, 3. click on the "Fenix - assemble" task, then click "Run Artifacts". 4. the APK links should be on the left side of the screen, named for each CPU architecture **Same strings used for ETP preferences and titles for info pages (Strict and Standard)** <table style="width:100%"> <tr> <th>Menu</th> <th>Standard</th> <th>Strict</th> </tr> <tr> <td><img src="https://user-images.githubusercontent.com/1709373/67006748-9689b280-f0ee-11e9-8a08-a9b76ca0d225.png" width="200px" /></td> <td><img src="https://user-images.githubusercontent.com/1709373/67006749-9689b280-f0ee-11e9-9fe3-a7b3054f59c9.png" width="200px" /></td> <td><img src="https://user-images.githubusercontent.com/1709373/67006750-97224900-f0ee-11e9-82b6-2f9b41cff532.png" width="200px" /></td> </tr> </table> 6125: Don't show fingerprinters section of the standard tracking policy UI 🤞🏻 r=ekager a=starkej2 ## Description Removes the fingerprinters item from the standard tracking policy UI. Resolves #6108 ## Screenshots / GIFs Standard Mode | Strict Mode Co-authored-by: Sören Hentzschel <kontakt@agenedia.com> Co-authored-by: Mihai Branescu <branescu.mihai2@gmail.com> Co-authored-by: Jeffrey Starke <starkej2@gmail.com>
Timed out (retrying...) |
1 similar comment
Timed out (retrying...) |
ekager
added
the
pr:needs-landing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge
To download an APK when reviewing a PR:
Same strings used for ETP preferences and titles for info pages (Strict and Standard)