This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Fixes #5323: Show a snackbar while browsing data is deleting. #6105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekager
approved these changes
Oct 19, 2019
app/src/main/res/values/strings.xml
Outdated
| @@ -738,6 +738,8 @@ | |||
| <string name="delete_browsing_data_prompt_allow">Delete</string> | |||
| <!-- Text for the snackbar confirmation that the data was deleted --> | |||
| <string name="preferences_delete_browsing_data_snackbar">Browsing data deleted</string> | |||
| <!-- Text for the snackbar to show the user that the deletion of browsing data is in progress --> | |||
| <string name="deleting_browsing_data_in_progress">Deleting browsing data…</string> | |||
There was a problem hiding this comment.
I think we want to use … for the ellipsize here like in onboarding_firefox_account_signing_in
ekager
added
the
pr:needs-landing
Codecov Report
@@ Coverage Diff @@
## master #6105 +/- ##
===========================================
- Coverage 14.32% 14.3% -0.02%
Complexity 326 326
===========================================
Files 261 261
Lines 10725 10735 +10
Branches 1565 1569 +4
===========================================
Hits 1536 1536
- Misses 9065 9073 +8
- Partials 124 126 +2
Continue to review full report at Codecov.
|
…eting. I set the snackbar length indefinite because it should show while the browsing data is deleting. After that the snackbar is dismissed. In BaseBrowserFragment I didn't set an anchor for the snackbar because browserToolbarView is initialized after DefaultBrowserToolbarController constructor where I pass the snackbar as a parameter (browserToolbarView needs browserInteractor who needs browserToolbarController, so I couldn't change the initialization order). The only solution I found was to pass the snackbar to DefaultBrowserToolbarController via a setter but this would bypass our current architecture.
ValentinTimisica
force-pushed
the
b-5323
branch
from
59e1e34
to
ed606ee
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I set the snackbar length indefinite because it should show while the
browsing data is deleting. After that the snackbar is dismissed.
In BaseBrowserFragment I didn't set an anchor for the snackbar because
browserToolbarView is initialized after DefaultBrowserToolbarController
constructor where I pass the snackbar as a parameter (browserToolbarView
needs browserInteractor who needs browserToolbarController, so I
couldn't change the initialization order). The only solution I found was
to pass the snackbar to DefaultBrowserToolbarController via a setter but
this would bypass our current architecture.
Pull Request checklist
After merge
To download an APK when reviewing a PR: