Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Clean up automation folder from what was used by the old decision task #6115

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

JohanLorenzo
Copy link
Contributor


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

def write_secret_to_file(path, data, key, base64decode=False, json_secret=False, append=False, prefix=''):
path = os.path.join(os.path.dirname(__file__), '../../../' + path)
path = os.path.abspath(os.path.join(os.path.dirname(__file__), '../../' + path))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-io
Copy link

codecov-io commented Oct 18, 2019

Codecov Report

Merging #6115 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #6115      +/-   ##
===========================================
- Coverage     14.31%   14.3%   -0.02%     
  Complexity      324     324              
===========================================
  Files           259     259              
  Lines         10692   10700       +8     
  Branches       1559    1560       +1     
===========================================
  Hits           1531    1531              
- Misses         9036    9044       +8     
  Partials        125     125
Impacted Files Coverage Δ Complexity Δ
...ug/java/org/mozilla/fenix/DebugFenixApplication.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f41783c...dd5a1a5. Read the comment docs.

Copy link
Contributor

@mitchhentges mitchhentges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this cleanup!

@JohanLorenzo
Copy link
Contributor Author

bors r=mitchhentges

bors bot pushed a commit that referenced this pull request Oct 22, 2019
6115: Clean up automation folder from what was used by the old decision task r=mitchhentges a=JohanLorenzo



Co-authored-by: Johan Lorenzo <jlorenzo@mozilla.com>
@bors
Copy link

bors bot commented Oct 22, 2019

Build failed

  • test-debug
  • build-debug
  • test-ui

@JohanLorenzo
Copy link
Contributor Author

Compilation errors that will likely be solved at the next AC snapshot.

@JohanLorenzo
Copy link
Contributor Author

bors r=mitchhentges

bors bot pushed a commit that referenced this pull request Oct 23, 2019
6115: Clean up automation folder from what was used by the old decision task r=mitchhentges a=JohanLorenzo



Co-authored-by: Johan Lorenzo <jlorenzo@mozilla.com>
@bors
Copy link

bors bot commented Oct 23, 2019

Build succeeded

  • test-debug
  • lint-ktlint
  • build-debug
  • test-ui
  • lint-compare-locales
  • lint-detekt
  • lint-lint

@bors bors bot merged commit dd5a1a5 into mozilla-mobile:master Oct 23, 2019
@JohanLorenzo JohanLorenzo deleted the cleanup-automation branch October 23, 2019 07:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants