Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Added UI tests for the Submenu About settings. #6161

Merged
merged 1 commit into from
Dec 27, 2019

Conversation

KMaragh
Copy link
Contributor

@KMaragh KMaragh commented Oct 21, 2019


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@ghost
Copy link

ghost commented Oct 21, 2019

No Taskcluster jobs started for this pull request
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

@rpappalax rpappalax self-requested a review November 8, 2019 22:31
@rpappalax rpappalax added eng:automation Build automation, Continuous integration, .. pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on labels Nov 8, 2019
@rpappalax rpappalax removed the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Dec 17, 2019
@codecov-io
Copy link

codecov-io commented Dec 17, 2019

Codecov Report

Merging #6161 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6161      +/-   ##
============================================
- Coverage     18.98%   18.93%   -0.06%     
  Complexity      436      436              
============================================
  Files           291      289       -2     
  Lines         11272    11298      +26     
  Branches       1530     1542      +12     
============================================
- Hits           2140     2139       -1     
- Misses         8969     8995      +26     
- Partials        163      164       +1
Impacted Files Coverage Δ Complexity Δ
...ix/trackingprotection/TrackingProtectionOverlay.kt 96.87% <0%> (-0.19%) 9% <0%> (ø)
...rc/main/java/org/mozilla/fenix/FenixApplication.kt 4.71% <0%> (-0.1%) 2% <0%> (ø)
.../bookmarks/viewholders/BookmarkFolderViewHolder.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...kmarks/selectfolder/SelectBookmarkFolderAdapter.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../settings/search/EditCustomSearchEngineFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...a/fenix/settings/DefaultBrowserSettingsFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...lla/fenix/components/toolbar/BrowserToolbarView.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...main/java/org/mozilla/fenix/components/Services.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../src/main/java/org/mozilla/fenix/utils/Settings.kt 72.77% <0%> (ø) 19% <0%> (ø) ⬇️
...in/java/org/mozilla/fenix/search/SearchFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24f1846...10a2ce8. Read the comment docs.

@KMaragh KMaragh force-pushed the about-settings-test branch 2 times, most recently from e555bf1 to a8e37ce Compare December 18, 2019 17:33
Copy link
Contributor

@AaronMT AaronMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start @KMaragh – just a couple questions and some cleanup. As well, make sure to enable in Android Studio the following:
Screen Shot 2019-12-18 at 4 39 00 PM and then run Analyze -> Inspect Code -> Uncommited Files to check for any Kotlin style issues

Copy link
Contributor

@rpappalax rpappalax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after squash, rebase and nit fixes from Aaron and I, we can merge this 👍

@KMaragh
Copy link
Contributor Author

KMaragh commented Dec 27, 2019

Great start @KMaragh – just a couple questions and some cleanup. As well, make sure to enable in Android Studio the following:
Screen Shot 2019-12-18 at 4 39 00 PM and then run Analyze -> Inspect Code -> Uncommited Files to check for any Kotlin style issues

Thanks for the suggestions! I made the changes, but I can't seem to close out this review so I will ask Richard to close.

@rpappalax rpappalax dismissed AaronMT’s stale review December 27, 2019 15:54

@KMaragh has reviewed and just need to unblock this so we can merge. thanks!

@rpappalax rpappalax merged commit e22d092 into mozilla-mobile:master Dec 27, 2019
@KMaragh KMaragh deleted the about-settings-test branch December 27, 2019 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:automation Build automation, Continuous integration, ..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants