-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Added UI tests for the Submenu About settings. #6161
Conversation
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
5ef0fd6
to
019943e
Compare
019943e
to
568f337
Compare
568f337
to
fcf525b
Compare
fcf525b
to
26d1360
Compare
26d1360
to
9241c66
Compare
Codecov Report
@@ Coverage Diff @@
## master #6161 +/- ##
============================================
- Coverage 18.98% 18.93% -0.06%
Complexity 436 436
============================================
Files 291 289 -2
Lines 11272 11298 +26
Branches 1530 1542 +12
============================================
- Hits 2140 2139 -1
- Misses 8969 8995 +26
- Partials 163 164 +1
Continue to review full report at Codecov.
|
e555bf1
to
a8e37ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start @KMaragh – just a couple questions and some cleanup. As well, make sure to enable in Android Studio the following:
and then run
Analyze -> Inspect Code -> Uncommited Files
to check for any Kotlin style issues
app/src/androidTest/java/org/mozilla/fenix/helpers/TestHelper.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/SettingsAboutTest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/SettingsAboutTest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/BrowserRobot.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsRobot.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsRobot.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsRobot.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after squash, rebase and nit fixes from Aaron and I, we can merge this 👍
app/src/androidTest/java/org/mozilla/fenix/ui/SettingsAboutTest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/SettingsAboutTest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsRobot.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuAboutRobot.kt
Outdated
Show resolved
Hide resolved
1021ef4
to
10a2ce8
Compare
Thanks for the suggestions! I made the changes, but I can't seem to close out this review so I will ask Richard to close. |
@KMaragh has reviewed and just need to unblock this so we can merge. thanks!
Pull Request checklist
After merge
To download an APK when reviewing a PR: