Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #4947 - Add Fenix Beta icons. #6173

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Conversation

liuche
Copy link
Contributor

@liuche liuche commented Oct 21, 2019


This is also part of #109, to get our closed Firefox Preview Beta channel up and running. It looks like the releng bits have landed, so let's get these icons in too.

Did a quick test by building this with geckoBetaFenixBeta variant, saw the icons.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@boek
Copy link
Contributor

boek commented Oct 22, 2019

This may need the changes that landed in master today to fix the build failures

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@40cda1d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #6173   +/-   ##
========================================
  Coverage          ?   14.3%           
  Complexity        ?     326           
========================================
  Files             ?     261           
  Lines             ?   10756           
  Branches          ?    1572           
========================================
  Hits              ?    1539           
  Misses            ?    9090           
  Partials          ?     127

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40cda1d...7871c29. Read the comment docs.

@liuche liuche merged commit 0f23679 into mozilla-mobile:master Oct 23, 2019
@liuche liuche deleted the beta-icons branch October 23, 2019 01:10
mcarare pushed a commit to mcarare/fenix that referenced this pull request Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants