This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
History menu UI tests #6272
Merged
History menu UI tests #6272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6272 +/- ##
============================================
- Coverage 14.49% 14.42% -0.07%
+ Complexity 323 321 -2
============================================
Files 272 272
Lines 11039 11035 -4
Branches 1593 1592 -1
============================================
- Hits 1600 1592 -8
- Misses 9311 9317 +6
+ Partials 128 126 -2
Continue to review full report at Codecov.
|
AaronMT
reviewed
Oct 25, 2019
app/src/androidTest/java/org/mozilla/fenix/ui/robots/HistoryRobot.kt
Outdated
Show resolved
Hide resolved
rpappalax
suggested changes
Oct 25, 2019
There was a problem hiding this comment.
Once the suggestions @AaronMT and I highlighted (as well as passing on taskcluster and rebase to master), this looks super good and can be merged. Great work @sv-ohorvath !
app/src/androidTest/java/org/mozilla/fenix/ui/robots/HistoryRobot.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/HistoryRobot.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/HomeScreenRobot.kt
Outdated
Show resolved
Hide resolved
sv-ohorvath
force-pushed
the
historyTests
branch
from
5a05431
to
a85c738
Compare
|
@rpappalax I moved some things to a new MultipleSelectionToolbarRobot, but the functionality is still the same. Please have another look. |
sv-ohorvath
force-pushed
the
historyTests
branch
from
a85c738
to
12157a6
Compare
rpappalax
approved these changes
Oct 28, 2019
app/src/androidTest/java/org/mozilla/fenix/ui/robots/MultipleSelectionToolbarRobot.kt
Outdated
Show resolved
Hide resolved
Removed failing verifyOverflowMenuButton method Added new Robot for MultipleSelectionTooolbar Renamed MultipleSelectionToolbarRobot to LibrarySubMenusMultipleSelectionToolbarRobot
sv-ohorvath
force-pushed
the
historyTests
branch
from
12157a6
to
517e2b7
Compare
sv-ohorvath
added
the
eng:automation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ads UI tests for the History menu
Removed the failing verifyOverflowMenuButton method
Added new Robot for MultipleSelectionTooolbar
Pull Request checklist
After merge
To download an APK when reviewing a PR: