Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Adding UI tests for the Basic Menu settings. 🎲 !!!! #6346

Merged
merged 2 commits into from
Feb 6, 2020
Merged

Adding UI tests for the Basic Menu settings. 🎲 !!!! #6346

merged 2 commits into from
Feb 6, 2020

Conversation

KMaragh
Copy link
Contributor

@KMaragh KMaragh commented Oct 30, 2019 •
edited
Loading

Pull Request checklist

  • [X ] Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • [ X] Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • [X ] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@ghost
Copy link

ghost commented Oct 30, 2019

No Taskcluster jobs started for this pull request 
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

@KMaragh
Copy link
Contributor Author

KMaragh commented Oct 30, 2019

The PR isn't finished yet because I am running into issues with Gecko not loading an SQLite library. It looks like the app is missing this file: /data/user/0/org.mozilla.fenix.debug/app_experiments-service/experiments.json.

Currently trying to figure out why this is the case.

@rpappalax rpappalax self-requested a review October 30, 2019 16:30
@rpappalax rpappalax added eng:automation Build automation, Continuous integration, .. pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on labels Oct 30, 2019
@codecov-io
Copy link

codecov-io commented Oct 30, 2019 •
edited
Loading

Codecov Report

Merging #6346 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6346      +/-   ##
============================================
- Coverage     18.78%   18.77%   -0.01%     
  Complexity      454      454              
============================================
  Files           315      315              
  Lines         12300    12301       +1     
  Branches       1617     1617              
============================================
  Hits           2310     2310              
- Misses         9790     9791       +1     
  Partials        200      200
Impacted Files Coverage Δ Complexity Δ
...lla/fenix/browser/CustomTabContextMenuCandidate.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6019ada...001edf9. Read the comment docs.

@AaronMT
Copy link
Contributor

AaronMT commented Nov 5, 2019

Did you want to re-base and try again? I think there was something wrong with the devices at the time of execution.

@KMaragh
Copy link
Contributor Author

KMaragh commented Nov 6, 2019

Will make an update to this today :). I will rebase and try again

@KMaragh KMaragh changed the title Adding UI tests for the Basic Menu settings. (WIP) Adding UI tests for the Basic Menu settings. Dec 17, 2019
@rpappalax rpappalax removed the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Dec 17, 2019
AaronMT
AaronMT previously requested changes Dec 20, 2019
View reviewed changes
app/src/androidTest/java/org/mozilla/fenix/helpers/matchers/BitmapDrawableMatcher.kt Show resolved Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/SettingsBasicsTest.kt Outdated Show resolved Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/SettingsBasicsTest.kt Outdated Show resolved Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/SettingsBasicsTest.kt Outdated Show resolved Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/SettingsBasicsTest.kt Outdated Show resolved Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/SearchRobot.kt Outdated Show resolved Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/SearchRobot.kt Show resolved Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/SearchRobot.kt Outdated Show resolved Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuDefaultBrowserRobot.kt Outdated Show resolved Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/SettingsBasicsTest.kt Show resolved Hide resolved
@KMaragh KMaragh requested a review from rpappalax January 8, 2020 21:34
rpappalax
rpappalax approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@rpappalax rpappalax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 👍

app/src/androidTest/java/org/mozilla/fenix/ui/SettingsBasicsTest.kt Outdated Show resolved Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/SettingsBasicsTest.kt Outdated Show resolved Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/HomeScreenRobot.kt Outdated Show resolved Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/HomeScreenRobot.kt Outdated Show resolved Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/HomeScreenRobot.kt Outdated Show resolved Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuAccessibilityRobot.kt Outdated Show resolved Hide resolved
@KMaragh KMaragh force-pushed the 3dot-menu-basics-test branch 2 times, most recently from dc1e394 to 36fc73f Compare January 10, 2020 16:57
@KMaragh KMaragh self-assigned this Jan 13, 2020
@boek boek changed the title Adding UI tests for the Basic Menu settings. Adding UI tests for the Basic Menu settings. 🎲 Jan 13, 2020
@KMaragh KMaragh force-pushed the 3dot-menu-basics-test branch 2 times, most recently from 130030a to 9a8e097 Compare January 22, 2020 20:25
@liuche liuche changed the title Adding UI tests for the Basic Menu settings. 🎲 Adding UI tests for the Basic Menu settings. 🎲 !! Jan 25, 2020
@KMaragh KMaragh force-pushed the 3dot-menu-basics-test branch 2 times, most recently from 397e3be to 45b2b8e Compare February 3, 2020 17:14
@KMaragh
Copy link
Contributor Author

KMaragh commented Feb 3, 2020

Updated some text in the accessibility settings.

@KMaragh KMaragh changed the title Adding UI tests for the Basic Menu settings. 🎲 !! Adding UI tests for the Basic Menu settings. 🎲 !!! Feb 6, 2020
@KMaragh KMaragh changed the title Adding UI tests for the Basic Menu settings. 🎲 !!! Adding UI tests for the Basic Menu settings. 🎲 !!!! Feb 6, 2020
@rpappalax rpappalax merged commit 095477e into mozilla-mobile:master Feb 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rpappalax rpappalax rpappalax approved these changes

@AaronMT AaronMT AaronMT left review comments

Assignees

@KMaragh KMaragh

Labels
eng:automation Build automation, Continuous integration, ..
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KMaragh @codecov-io @AaronMT @rpappalax