Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fixes #6344: Adds null check for adjust campaign #6348

Merged
merged 1 commit into from
Oct 30, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Oct 30, 2019


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sblatz sblatz requested a review from csadilek October 30, 2019 16:00
@codecov-io
Copy link

codecov-io commented Oct 30, 2019

Codecov Report

Merging #6348 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6348      +/-   ##
============================================
- Coverage     14.47%   14.47%   -0.01%     
  Complexity      323      323              
============================================
  Files           272      272              
  Lines         11037    11038       +1     
  Branches       1593     1594       +1     
============================================
  Hits           1598     1598              
- Misses         9310     9311       +1     
  Partials        129      129
Impacted Files Coverage Δ Complexity Δ
...a/fenix/components/metrics/AdjustMetricsService.kt 3.44% <0%> (-0.13%) 1 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8481b0a...7eba3e9. Read the comment docs.

Copy link
Contributor

@csadilek csadilek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Since this is easy to break and causing lots of crashes when it does, let's file a follow-up to guard with a test? This will likely take a bit of time, so let's land to fix the crashes.

@sblatz sblatz merged commit fd22c43 into mozilla-mobile:master Oct 30, 2019
@severinrudie severinrudie mentioned this pull request Nov 6, 2019
30 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants