Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

No issue: Ignore rest of HistoryTest tests #6450

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

ekager
Copy link
Contributor

@ekager ekager commented Nov 5, 2019


I'm still seeing failures for ShareTest in HistoryTest on PRs so let's ignore them all until we can figure out #5462 for API 25 testing
FYI @rpappalax

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-io
Copy link

codecov-io commented Nov 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@1ee0703). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #6450   +/-   ##
========================================
  Coverage          ?   16.5%           
  Complexity        ?     352           
========================================
  Files             ?     277           
  Lines             ?   11149           
  Branches          ?    1597           
========================================
  Hits              ?    1840           
  Misses            ?    9159           
  Partials          ?     150

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ee0703...73668ba. Read the comment docs.

@sblatz sblatz merged commit cf8cab8 into mozilla-mobile:master Nov 5, 2019
@severinrudie severinrudie mentioned this pull request Nov 6, 2019
30 tasks
@ekager ekager deleted the history-test-ignore branch August 21, 2020 20:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants