This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
No issue: correct glean links in telemetry.md #6488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6488 +/- ##
=========================================
Coverage 16.45% 16.45%
Complexity 354 354
=========================================
Files 276 276
Lines 11170 11170
Branches 1605 1605
=========================================
Hits 1838 1838
Misses 9178 9178
Partials 154 154Continue to review full report at Codecov.
|
Dexterp37
reviewed
Nov 7, 2019
| @@ -4,7 +4,7 @@ Fenix uses Mozilla's telemetry service (Glean) and LeanPlum to measure feature p | |||
|
|
|||
| ## Baseline ping | |||
|
|
|||
| Fenix creates and tries to send a "baseline" ping when the app goes to the background. This baseline ping is defined by the [Glean](https://github.com/mozilla-mobile/android-components/blob/master/components/service/glean/docs/pings/pings.md) component and [documented in the Android Components repository](https://github.com/mozilla-mobile/android-components/blob/master/components/service/glean/docs/pings/baseline.md). | |||
| Fenix creates and tries to send a "baseline" ping when the app goes to the background. This baseline ping is defined by the [Glean](https://github.com/mozilla/glean/tree/master/docs/user/pings) component and [documented in the Android Components repository](https://github.com/mozilla/glean/blob/master/docs/user/pings/baseline.md). | |||
There was a problem hiding this comment.
Does it make sense to replace the ping descriptions here with a link to this autogenerated doc? This doc, in addition to the metrics being sent, also contains ping descriptions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.