Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Changelog + issue validation automation script !!! #6509

Merged

Conversation

severinrudie
Copy link
Contributor

@severinrudie severinrudie commented Nov 8, 2019


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@severinrudie severinrudie changed the title FIX ME: first attempt at script for automating some changelog / issue… Changelog + issue validation automation script Nov 8, 2019
@severinrudie severinrudie force-pushed the no-issue-generate-changelog branch 2 times, most recently from 610ef03 to 9c7a2a3 Compare November 9, 2019 00:31
@severinrudie severinrudie mentioned this pull request Nov 9, 2019
5 tasks
@severinrudie severinrudie force-pushed the no-issue-generate-changelog branch 3 times, most recently from 9bf2ef8 to 85f94dd Compare November 9, 2019 00:40
@severinrudie severinrudie marked this pull request as ready for review November 9, 2019 00:40
@severinrudie severinrudie mentioned this pull request Nov 9, 2019
30 tasks
@liuche liuche changed the title Changelog + issue validation automation script Changelog + issue validation automation script !! Nov 26, 2019
@liuche liuche changed the title Changelog + issue validation automation script !! Changelog + issue validation automation script !!! Nov 26, 2019
Copy link
Contributor

@liuche liuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, and this is only printing something out so.

@codecov-io
Copy link

codecov-io commented Nov 26, 2019

Codecov Report

Merging #6509 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #6509   +/-   ##
========================================
  Coverage      17.3%   17.3%           
  Complexity      391     391           
========================================
  Files           281     281           
  Lines         11225   11225           
  Branches       1546    1546           
========================================
  Hits           1942    1942           
  Misses         9128    9128           
  Partials        155     155

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 769c1e4...ebc4b28. Read the comment docs.

@liuche liuche merged commit 18edad9 into mozilla-mobile:master Nov 26, 2019
@liuche liuche mentioned this pull request Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants