Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #2294 - History URL is cut with a large font set #6724

Conversation

vespertineSiren
Copy link
Contributor


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

Tested on Samsung Note Android 9.

Before
Screenshot_1574273743

After:
Screenshot_1574274039

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@firefoxci-taskcluster
Copy link

No Taskcluster jobs started for this pull request
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

@ekager ekager changed the title For #2294 - History URL is cut with a large font set For #2294 - History URL is cut with a large font set. Nov 20, 2019
@codecov-io
Copy link

codecov-io commented Nov 20, 2019

Codecov Report

Merging #6724 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6724   +/-   ##
=========================================
  Coverage     17.27%   17.27%           
  Complexity      385      385           
=========================================
  Files           280      280           
  Lines         11256    11256           
  Branches       1588     1588           
=========================================
  Hits           1944     1944           
  Misses         9152     9152           
  Partials        160      160

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f18c047...285d71d. Read the comment docs.

@ekager ekager changed the title For #2294 - History URL is cut with a large font set. For #2294 - History URL is cut with a large font set Nov 20, 2019
@ekager ekager force-pushed the history_librarysiteitemview_clipping_bug_fix branch from a07bd97 to 285d71d Compare November 21, 2019 22:38
@ekager ekager added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Nov 21, 2019
@NotWoods NotWoods merged commit 3e436f5 into mozilla-mobile:master Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants