Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Update the Lifecycle dependency to 2.2.0-rc02 #6780

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

Dexterp37
Copy link
Contributor

@Dexterp37 Dexterp37 commented Nov 25, 2019

The changelog lives here.
This is another attempt to fix the oddities being detected by Glean in Fenix: 'baseline' ping are not being sent for a certain subset of users, 'metrics' pings are.

Other fixes that we tried before (proguard rules, using legacy classes from the Lifecycle library) made things better, but the problem doesn't appear to be fixed yet, on Nightly.

Updating to this newer would help due to this specific fix:

"Fixed a bug in the proguard setup of the library that affected devices running API 28+ if the target API is below 29. (b/142778206)"

cc @liuche @sblatz @mdboom


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

The changelog [lives here](https://developer.android.com/jetpack/androidx/releases/lifecycle#2.2.0-rc02).
This is another attempt to fix the oddities being detected by
Glean in Fenix: 'baseline' ping are not being sent for a certain
subset of users, 'metrics' pings are.
@Dexterp37 Dexterp37 requested a review from boek November 25, 2019 10:04
@Dexterp37 Dexterp37 self-assigned this Nov 25, 2019
@codecov-io
Copy link

codecov-io commented Nov 25, 2019

Codecov Report

Merging #6780 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #6780   +/-   ##
========================================
  Coverage      17.3%   17.3%           
  Complexity      390     390           
========================================
  Files           280     280           
  Lines         11204   11204           
  Branches       1574    1574           
========================================
  Hits           1939    1939           
  Misses         9111    9111           
  Partials        154     154

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8271f0f...1fe3974. Read the comment docs.

@boek boek merged commit d69db50 into mozilla-mobile:master Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants