Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #6791: Attempts to fit SavedLoginsAdapater crash #6815

Closed
wants to merge 1 commit into from

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Nov 26, 2019


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

Copy link
Contributor

@NotWoods NotWoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

private val interactor: SavedLoginsInteractor
) : ListAdapter<SavedLoginsItem, SavedLoginsListItemViewHolder>(DiffCallback) {

override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): SavedLoginsListItemViewHolder {
val view = LayoutInflater.from(parent.context).inflate(viewType, parent, false)
val view = LayoutInflater.from(context).inflate(viewType, parent, false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure we need to inflate the correct view here. I'm going to close this and we'll open a new PR that fixes this

@boek boek closed this Nov 27, 2019
@codecov-io
Copy link

Codecov Report

Merging #6815 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #6815      +/-   ##
===========================================
+ Coverage      17.3%   17.3%   +<.01%     
+ Complexity      391     390       -1     
===========================================
  Files           281     280       -1     
  Lines         11225   11204      -21     
  Branches       1546    1574      +28     
===========================================
- Hits           1942    1939       -3     
+ Misses         9128    9111      -17     
+ Partials        155     154       -1
Impacted Files Coverage Δ Complexity Δ
...n/java/org/mozilla/fenix/logins/SavedLoginsView.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...ava/org/mozilla/fenix/logins/SavedLoginsAdapter.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...nix/components/toolbar/BrowserToolbarController.kt 59.45% <0%> (-0.68%) 0% <0%> (ø)
...la/fenix/components/metrics/GleanMetricsService.kt 7.3% <0%> (-0.24%) 3% <0%> (ø)
...org/mozilla/fenix/exceptions/ExceptionsFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...g/mozilla/fenix/library/history/HistoryFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...a/fenix/settings/DefaultBrowserSettingsFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...lla/fenix/components/toolbar/BrowserToolbarView.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ozilla/fenix/library/bookmarks/BookmarkFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...a/org/mozilla/fenix/library/LibraryPageFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a21540...75c0fac. Read the comment docs.

@ekager
Copy link
Contributor

ekager commented Dec 2, 2019

Correct, this does not fix the crash @boek

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants