Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Disabled all flaky History UI Tests. #6837

Merged
merged 1 commit into from
Dec 2, 2019
Merged

Conversation

sv-ohorvath
Copy link
Contributor

@sv-ohorvath sv-ohorvath commented Nov 27, 2019

Ignoring all the flaky history tests again.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sv-ohorvath sv-ohorvath changed the title Re-enabled all History Tests Re-enabled all History UI Tests Nov 27, 2019
@codecov-io
Copy link

codecov-io commented Nov 27, 2019

Codecov Report

Merging #6837 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6837   +/-   ##
=========================================
  Coverage     17.32%   17.32%           
  Complexity      390      390           
=========================================
  Files           281      281           
  Lines         11207    11207           
  Branches       1544     1544           
=========================================
  Hits           1942     1942           
  Misses         9114     9114           
  Partials        151      151

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e0138...7e3e505. Read the comment docs.

@boek
Copy link
Contributor

boek commented Nov 27, 2019

Looks like the historytest is still failing on a device. Also ktlint is failing?

@sv-ohorvath sv-ohorvath added pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on eng:automation Build automation, Continuous integration, .. labels Nov 28, 2019
@sv-ohorvath
Copy link
Contributor Author

sv-ohorvath commented Nov 28, 2019

Looks like the historytest is still failing on a device. Also ktlint is failing?

ktlint is failing on this PR with "unused import" on the "org.junit.Rule" import which is obviously in use. I'll have a look.

I just saw that sometimes the history list is empty, causing the failures. :( I'll need to figure that out.

@sv-ohorvath sv-ohorvath changed the title Re-enabled all History UI Tests [WIP] Re-enabled all History UI Tests Nov 28, 2019
Copy link
Contributor

@AaronMT AaronMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert. We should keep this disabled while investigating.

@sv-ohorvath
Copy link
Contributor Author

Due to #6859 and the tests failing on this PR check, I've disabled again all the possible flaky tests while I'm doing some more investigation.

@sv-ohorvath sv-ohorvath changed the title [WIP] Re-enabled all History UI Tests Disabled all flaky History UI Tests Nov 29, 2019
@sv-ohorvath sv-ohorvath removed the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Nov 29, 2019
@AaronMT AaronMT removed the request for review from rpappalax November 29, 2019 14:58
@sv-ohorvath sv-ohorvath changed the title Disabled all flaky History UI Tests Disabled all flaky History UI Tests Nov 29, 2019
@sv-ohorvath sv-ohorvath changed the title Disabled all flaky History UI Tests Disabled all flaky History UI Tests. Nov 29, 2019
@AaronMT AaronMT merged commit 715a79d into master Dec 2, 2019
@bors bors bot deleted the fixHistoryFlakyTests branch December 2, 2019 00:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:automation Build automation, Continuous integration, ..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants