This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #5366 vector drawable compat #6904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kglazko
force-pushed
the
Issue5366VectorDrawableCompat
branch
from
64f9550
to
1ce19e4
Compare
Codecov Report
@@ Coverage Diff @@
## master #6904 +/- ##
========================================
Coverage 18.6% 18.6%
Complexity 413 413
========================================
Files 282 282
Lines 11165 11165
Branches 1524 1524
========================================
Hits 2077 2077
Misses 8926 8926
Partials 162 162
Continue to review full report at Codecov.
|
kglazko
force-pushed
the
Issue5366VectorDrawableCompat
branch
from
1ce19e4
to
c7812c3
Compare
kglazko
changed the title
kglazko
force-pushed
the
Issue5366VectorDrawableCompat
branch
from
53da173
to
f05a3a1
Compare
NotWoods
suggested changes
Dec 3, 2019
| @@ -24,7 +24,7 @@ | |||
| android:layout_marginStart="16dp" | |||
| android:layout_marginTop="16dp" | |||
| android:importantForAccessibility="no" | |||
| android:src="@drawable/ic_tab_collection" | |||
| app:srcCompat="@drawable/ic_tab_collection" | |||
There was a problem hiding this comment.
nit: indentation is slightly off here
| @@ -35,7 +35,8 @@ class DownloadNotificationBottomSheetDialog( | |||
| download_notification_title.text = | |||
| context.getString(R.string.mozac_feature_downloads_failed_notification_text2) | |||
|
|
|||
| download_notification_icon.setImageDrawable(context.getDrawable( | |||
| download_notification_icon.setImageDrawable( | |||
| context.getDrawable( | |||
There was a problem hiding this comment.
This file should be reverted since there were only whitespace changes
| @@ -28,7 +28,7 @@ | |||
| android:layout_width="wrap_content" | |||
| android:layout_height="wrap_content" | |||
| android:importantForAccessibility="no" | |||
| android:src="@drawable/ic_tab_collection" | |||
| app:srcCompat="@drawable/ic_tab_collection" | |||
There was a problem hiding this comment.
nit: indentation is slightly off here
| @@ -121,7 +121,7 @@ | |||
| android:layout_margin="16dp" | |||
| android:background="?android:attr/selectableItemBackground" | |||
| android:contentDescription="@string/create_collection_close" | |||
| android:src="@drawable/mozac_ic_close" | |||
| app:srcCompat="@drawable/mozac_ic_close" | |||
There was a problem hiding this comment.
nit: indentation is slightly off here
kglazko
force-pushed
the
Issue5366VectorDrawableCompat
branch
from
1f6d24c
to
3fc282a
Compare
kglazko
changed the title
kglazko
force-pushed
the
Issue5366VectorDrawableCompat
branch
from
3fc282a
to
def3472
Compare
kglazko
force-pushed
the
Issue5366VectorDrawableCompat
branch
from
def3472
to
1a47834
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge
To download an APK when reviewing a PR: