Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #6957 - Update Slack invite link #7072

Merged
merged 2 commits into from
Dec 10, 2019
Merged

For #6957 - Update Slack invite link #7072

merged 2 commits into from
Dec 10, 2019

Conversation

ekager
Copy link
Contributor

@ekager ekager commented Dec 10, 2019


Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@ekager ekager requested a review from sblatz December 10, 2019 18:46
Copy link
Contributor

@sblatz sblatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one addition

README.md Outdated
@@ -39,7 +39,7 @@ Before you attempt to make a contribution please read the [Community Participati

* Browse our [current Issues](https://github.com/mozilla-mobile/fenix/issues), or [file a security issue][sec issue].

* Slack: [#fenix on mozilla-android.slack.com](mozilla-android.slack.com) | [Join here](https://join.slack.com/t/mozilla-android/shared_invite/enQtNzk3NDczMzc0ODMzLWNjYTQ5MjA3ZDI0NzNhOTBjMWUyMmNmZDcwM2ZhY2YxZjdjMWIwZWY1YmQ3NjJmMDNkODYxMmRmNTdjNGJmMTU)
* Slack: [#fenix on mozilla-android.slack.com](mozilla-android.slack.com) | [Join here](https://join.slack.com/t/mozilla-android/shared_invite/enQtODU0ODk2MTgyMjQyLTU5MWU1ZGJkOGRjZmFjOTg2MTE1ZjlmNTU5ZTc5MDc4NjA1MmM0MjQ5Yjg1N2IzMjZjMGVmOTE0MzI1ZjQ3MTA)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also get rid of the hyperlink here because it's also broken.
[#fenix on mozilla-android.slack.com](mozilla-android.slack.com) -> #fenix on mozilla-android.slack.com

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

@codecov-io
Copy link

codecov-io commented Dec 10, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@f5f0cb8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7072   +/-   ##
=========================================
  Coverage          ?   18.73%           
  Complexity        ?      429           
=========================================
  Files             ?      285           
  Lines             ?    11202           
  Branches          ?     1529           
=========================================
  Hits              ?     2099           
  Misses            ?     8942           
  Partials          ?      161

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5f0cb8...6689756. Read the comment docs.

@NotWoods NotWoods merged commit 6551f31 into master Dec 10, 2019
@NotWoods NotWoods deleted the ekager-patch-1 branch December 10, 2019 20:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants