Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Closes #6139: Removes bors #7247

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Dec 17, 2019

I'm sorry, Dave, I'm afraid I can't do that.


Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

I'm sorry, Dave, I'm afraid I can't do that.
@codecov-io
Copy link

codecov-io commented Dec 17, 2019

Codecov Report

Merging #7247 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7247   +/-   ##
=========================================
  Coverage     18.93%   18.93%           
  Complexity      436      436           
=========================================
  Files           289      289           
  Lines         11298    11298           
  Branches       1542     1542           
=========================================
  Hits           2139     2139           
  Misses         8995     8995           
  Partials        164      164

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0b9ad7...836ef14. Read the comment docs.

Copy link
Contributor

@JohanLorenzo JohanLorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

To future readers: please see #6139 (comment) to understand why I'm okay to remove bors from Fenix.

@sblatz sblatz merged commit 99f3804 into mozilla-mobile:master Dec 17, 2019
JohanLorenzo added a commit to JohanLorenzo/fenix that referenced this pull request Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants